summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* style.css: Switch the header to a grey themeRunxi Yu2024-10-011-4/+8
|
* style.css: Revert back to blue themeRunxi Yu2024-10-011-3/+5
|
* {ws,wsm}.go: Split message handlers into their own functionsRunxi Yu2024-10-012-124/+182
|
* lint.sh: Disable dogsled and unparamRunxi Yu2024-10-011-1/+1
| | | | | | | dogsled forbids patterns such as "_, _, _ = a, b, c" for no reason. unparam warns about unused parameters even when I'm assigning them to _ to indicate that it's fine for them to be unused.
* {auth,ws}.go: Remove unnecessary TODOsRunxi Yu2024-10-012-19/+2
|
* ws.go: Allow deselecting coursesRunxi Yu2024-10-011-0/+34
|
* lint.sh: Disable yet another cyclomatic complexity checkerRunxi Yu2024-10-011-1/+1
|
* ws.go: Fix logic error when reaffirming a course choiceRunxi Yu2024-10-011-2/+2
| | | | | | | | | | | | | | When a user has already chosen a course choice but sends a message to choose it again, a database error occurs as the uniqueness constraint is violated. In this case, we "reaffirm" the user's course choice, to hopefully get their client's state back in sync. However, we previously forgot to return back to the event loop after this reaffirmation, causing the control flow to fall into the course-increment and transaction-commit stage. The error is discovered at tx.Commit, where pgx raises a ErrTxCommitRollback, because in that case we're trying to commit a transaction that has already encountered an error.
* {main,pw}.go, Makefile, index_login.html: Remove password auth stubRunxi Yu2024-10-014-92/+1
| | | | | | | | | | I don't think password authentication is really useful, since Microsoft Entra ID is the "proper" way of doing authentication in our school system and there's just little reason to have a password login. I previously wanted to use password authentication for stress testing, but stress testing really could just use completely fake authentication and there's no need for any password whatsoever.
* ws.go: protocolError instead of R on unexpected database errorsRunxi Yu2024-10-011-23/+7
| | | | | | | When an unknown database error is encoutered, the connection should be considered broken and the error should be reported as a fatal error to the end user. Rejecting the course choice unsets the checkbox and lets the page to be continued to be used, which is not intended.
* index.go, ws.go: Fix race condition surrounding coursesRunxi Yu2024-10-012-13/+21
| | | | | | handleIndex and handleConn used to access the courses map without RLock'ing coursesLock, which may cause issues if courses is being written to, by a function such as setupCourses.
* courses.go: Propagate course.Selected when setting up coursesRunxi Yu2024-10-011-2/+7
|
* ws.go: Decrement course.Selected counter on commit failuresRunxi Yu2024-10-011-0/+6
|
* ws.go: Reaffirm course choice when duplicate is requestedRunxi Yu2024-10-011-5/+13
| | | | | | | | Laggy clients, extremely fast clicks, or other conditions could cause duplicate course choices to be sent, which would violate the uniqueness constraint. In this case the fact that the user has already chosen the course should be reaffirmed, rather than making it look like their choice was rejected.
* ws.go: propagateCouldFail -> propagateIgnoreFailuresRunxi Yu2024-10-011-2/+2
| | | | | | I think the new name better reflects the fact that it just ignores failures when propagating to each channel. The old name sounds like "this function itself could fail".
* ws.go, schema.sql: Enforce uniqueness of course choicesRunxi Yu2024-10-012-43/+65
| | | | References: https://todo.sr.ht/~runxiyu/cca/1
* lint.sh: Disable yet another cyclomatic complexity checkerRunxi Yu2024-10-011-1/+1
|
* ws.go, *.sql: Add course choices to the databaseRunxi Yu2024-10-013-7/+47
| | | | | | | | | | | | | | | | | | | | Note that this naive implementation currently allows users to submit multiple requests for the same course. See the TODO comment below: /* * TODO: Ensure that the user is not already enrolled in this course * and pay attention to relevant race conditions. It might be useful * to restructure this part, to begin a transaction that adds the user * to the database (and check the (currently not existing) uniqueness) * constraint at that exact moment, and abort the transaction if the * course limit is exceeded. * Or perhaps choices should be also stored in an internal data * structure, though that requires extra attention on consistency * issues between the internal data structure and the database. * (Sometime I should really go fix the LMDB bindings...) */ References: https://todo.sr.ht/~runxiyu/cca/1
* postgres_run.sh: Run in debug level 2Runxi Yu2024-10-011-1/+1
| | | | | This allows SQL statements to be logged which makes debugging much easier. Also "$@" is added so any extra arguments may be passed.
* ws.go: propagate -> propagateCouldFailRunxi Yu2024-10-011-3/+8
|
* ws.go: propagate course number updates in another goroutineRunxi Yu2024-10-011-1/+1
|
* auth.go: Add TODO about INSERTRunxi Yu2024-10-011-0/+7
|
* admin_handbook: List configuration caveatsRunxi Yu2024-09-301-3/+7
|
* iadocs: cover_page.{html->htm}Runxi Yu2024-09-302-353/+352
| | | | Cgit was kinda broken in serving HTML, it was a caching issue
* docs, iadocs: RevampRunxi Yu2024-09-306-352/+544
|
* docs: TeXinfo kinda sucks, removingRunxi Yu2024-09-303-57/+0
|
* ws.go: Separate c.Write calls into writeText()Runxi Yu2024-09-301-25/+17
|
* utils.go, auth.go: Rename random to randomBytesRunxi Yu2024-09-302-3/+3
|
* main.go: Actually repsect config.Perf.ReadHeaderTimeoutRunxi Yu2024-09-301-1/+1
|
* style.css: Misc enhancementsRunxi Yu2024-09-301-29/+25
|
* style.css: Break element specifiers onto its own line when longRunxi Yu2024-09-301-6/+12
|
* style.css: Rename --boxbg to --boxRunxi Yu2024-09-301-13/+11
|
* style.css: Add a dark themeRunxi Yu2024-09-301-8/+28
|
* style.css: Remove poorly-framed comment on --x-contrast colorsRunxi Yu2024-09-301-5/+0
|
* ws.go, utils.go: Document some synchronization design choicesRunxi Yu2024-09-302-1/+21
| | | | Also use TryLock in setupChanPool, and fail when not successful.
* index.html: Disable checkbox initially when .Selected >= MaxRunxi Yu2024-09-301-0/+4
|
* main.js: Move connect(s) to the event listener directlyRunxi Yu2024-09-301-6/+2
|
* {config,index}.go, cca.scfg.example, style.css, *.html: Link to sourceRunxi Yu2024-09-306-14/+17
|
* *: Change license to AGPL-3.0-or-laterRunxi Yu2024-09-3013-238/+787
|
* index.go: Correct typoRunxi Yu2024-09-301-1/+1
|
* auth.go, config.go, cca.scfg.example: Issue expiring cookiesRunxi Yu2024-09-303-2/+13
|
* {auth,index,ws}.go, schema.sql: Move session cookie into the user tableRunxi Yu2024-09-304-55/+23
| | | | | | | One user shall only have one session at a time. This reduces the possibility of strange race conditions and simplifies the code a lot. References: https://todo.sr.ht/~runxiyu/cca/4
* utils.go: Better logging for wstr()Runxi Yu2024-09-301-1/+1
|
* main.js: Disable boxes when fullRunxi Yu2024-09-301-0/+8
|
* main.js: Fix the IRC-style message parserRunxi Yu2024-09-301-0/+4
| | | | | Previously, if it receives a message like "a b :c", it returns "["a", "b", "c "]" which is erroneous.
* index.html, main.js, ws.go: Enhance course selection rejection messageRunxi Yu2024-09-303-5/+9
|
* main.js: Handle "Y" (course selection approved)Runxi Yu2024-09-291-0/+4
|
* style.css: Remove styling for preformatted textRunxi Yu2024-09-291-9/+0
|
* ws.go, config.go, config.scfg.example: Attempt to fix deadlockRunxi Yu2024-09-293-4/+14
| | | | | | | When propagate tries to propagate a message to a connection that actually called propagate, it deadlocks because the it tries to send to that connection's send channel in the same goroutine. This is an attempt at a fix.
* main.js: Handle number updatesRunxi Yu2024-09-291-0/+3
|
generated by cgit v1.2.3 (git 2.39.1) at 2024-10-16 23:21:17 +0000